Fix linter by using recent Python version#181
Merged
AlexanderWells-diamond merged 4 commits intomasterfrom Jan 20, 2025
Merged
Conversation
We have no particular reason to use 3.7 for this anymore
It seems newer versions don't handle inline comments
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #181 +/- ##
==========================================
- Coverage 88.19% 88.18% -0.01%
==========================================
Files 15 15
Lines 1271 1270 -1
==========================================
- Hits 1121 1120 -1
Misses 150 150 ☔ View full report in Codecov by Sentry. |
As best Michael and I can tell, the builder line was introduced during refactoring, and does nothing so can be safely deleted
AlexanderWells-diamond
force-pushed
the
fix_linter
branch
from
8f9bc4e to
f46fa89
Compare
Ubuntu 24 no longer supports Python 3.7. Its a lot of work to update the docs build to more modern python version
AlexanderWells-diamond
force-pushed
the
fix_linter
branch
from
f46fa89 to
685ab3e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes issues in the Docs and Code-lint stages of the CI.
The lint step has been updated to Python 3.12, along with fixing some minor issues it raised.
The Docs workflow has been pinned to an older Ubuntu version, as it is more work to update the Docs to a more recent Python version given our current reliance on the Pipfile.lock deployment mechanism.